fix: stop SSHKeysPage from flaking #10553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Nov 6, 2023
|
|
||
| useCustomEvent(SnackbarEventType, handleNotification); | ||
|
|
||
| const renderAdditionalMessage = (msg: AdditionalMessage, idx: number) => { |
There was a problem hiding this comment.
This got removed in favor of making it a separate component at the bottom of the file
Parkreiner
commented
Nov 6, 2023
| @@ -87,26 +42,27 @@ export const GlobalSnackbar: FC = () => { | |||
| key={notification.msg} | |||
| open={open} | |||
| variant={variantFromMsgType(notification.msgType)} | |||
| onClose={() => setOpen(false)} | |||
| autoHideDuration={notification.msgType === MsgType.Error ? 22000 : 6000} | |||
| anchorOrigin={{ vertical: "bottom", horizontal: "right" }} | |||
There was a problem hiding this comment.
All the prop changes here are just moving the single-line prop definitions so they're grouped together
aslilac
approved these changes
Nov 6, 2023
| @@ -87,26 +42,27 @@ export const GlobalSnackbar: FC = () => { | |||
| key={notification.msg} | |||
| open={open} | |||
| variant={variantFromMsgType(notification.msgType)} | |||
| onClose={() => setOpen(false)} | |||
| autoHideDuration={notification.msgType === MsgType.Error ? 22000 : 6000} | |||
| anchorOrigin={{ vertical: "bottom", horizontal: "right" }} | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10481
This fix updates
SSHKeys.tsxto prevent its tests from flaking.Changes made
<GlobalSnackbar>anduseCustomEventto simplify snackbar logicSSHKeys.tsxto process mutation errors solely through the snackbar, and not also the local UI