Skip to content

fix: display all metadata items alongside daily_cost #10554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Kira-Pilot
Copy link
Member

resolves #10411

We were inadvertently removing the last element of the metadata array if daily_cost was included in the resource metadata.

@Kira-Pilot Kira-Pilot requested review from a team and BrunoQuaresma and removed request for a team November 7, 2023 14:52
@BrunoQuaresma
Copy link
Collaborator

Those kinda of tests, that test how the component is rendered, would be better and easier tested using a storybook IMO or maybe it is already tested there - since when you change something in the render logic, it will be reflected there.

@Kira-Pilot
Copy link
Member Author

Those kinda of tests, that test how the component is rendered, would be better and easier tested using a storybook IMO or maybe it is already tested there - since when you change something in the render logic, it will be reflected there.

It is tested in Storybook very thoroughly, but I think we need additional jest tests because we didn't catch this bug with those visual tests. In particular, I want to assert that specific metadata stats are visible at certain times. The visual tests don't give any context so it is easy to approve without realizing a certain piece of data is missing or showing inappropriately.

@Kira-Pilot Kira-Pilot merged commit 4316c1c into main Nov 7, 2023
@Kira-Pilot Kira-Pilot deleted the daily-cost-metadata/kira-pilot branch November 7, 2023 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: daily_cost causes all coder_metadata not to show
2 participants