Skip to content

feat: add support for custom permissions in Helm chart rbac.yaml file #10590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 27, 2023
Merged

feat: add support for custom permissions in Helm chart rbac.yaml file #10590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
494d739
add feature to enable permission to manage Kubernates services inside…
lbi22 Nov 8, 2023
5523485
allow user to specify custom perms as a property
lbi22 Nov 9, 2023
6efc65f
Fix helm test generation
deansheather Nov 9, 2023
9e57830
fmt
matifali Nov 14, 2023
92b4f4b
fix lint
deansheather Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allow user to specify custom perms as a property
  • Loading branch information
@lbi22
lbi22 committed Nov 9, 2023
commit 5523485cc16231cf36d7289b725900260e39e6b7
18 changes: 15 additions & 3 deletions helm/coder/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,21 @@ coder:
# coder.serviceAccount.enableDeployments -- Provides the service account permission
# to manage Kubernetes deployments.
enableDeployments: true
# coder.serviceAccount.enableServices -- Provides the service account permission
# to manage Kubernetes services.
enableServices: false
# coder.serviceAccount.extraResources -- A list of service account permission
# to be menaged inside the workspace.
extraResources: []
# - apiGroups: [""]
# resources: ["services"]
# verbs:
# - create
# - delete
# - deletecollection
# - get
# - list
# - patch
# - update
# - watch

# coder.serviceAccount.annotations -- The Coder service account annotations.
annotations: {}
# coder.serviceAccount.name -- The service account name
Expand Down
14 changes: 2 additions & 12 deletions helm/libcoder/templates/_rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,8 @@ rules:
- update
- watch
{{- end }}
{{- if .Values.coder.serviceAccount.enableServices }}
- apiGroups: [""]
resources: ["services"]
verbs:
- create
- delete
- deletecollection
- get
- list
- patch
- update
- watch
{{- with .Values.coder.serviceAccount.extraResources }}
{{ toYaml . | nindent 2 }}
{{- end }}
---
apiVersion: rbac.authorization.k8s.io/v1
Expand Down