Skip to content

fix(scripts): forward all necessary ports for remote playwright #10606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(scripts): forward all necessary ports for remote playwright #10606

merged 1 commit into from
Nov 9, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Nov 9, 2023

Some tests were failing with #10445 due to a few more ports needing forwarding. In the future, we should make these ports configurable so that the test-suite is more robust against port-conflicts.

@mafredri mafredri self-assigned this Nov 9, 2023
@mafredri mafredri changed the title test(site): forward all necessary remote playwright ports test(site): forward all necessary ports for remote playwright Nov 9, 2023
@mafredri mafredri changed the title test(site): forward all necessary ports for remote playwright fix(scripts): forward all necessary ports for remote playwright Nov 9, 2023
@mafredri mafredri enabled auto-merge (squash) November 9, 2023 11:56
@mafredri mafredri added the hotfix label Nov 9, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Nov 9, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri mafredri merged commit 473585d into main Nov 9, 2023
@mafredri mafredri deleted the mafredri/e2e-remote-playwright-ports branch November 9, 2023 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
mtojek
mtojek reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge approval 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek