Skip to content

fix: add missing focus state styling to buttons and checkboxes #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2023
Merged

fix: add missing focus state styling to buttons and checkboxes #10614

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ca0298
fix: add focus styling to checkboxes
Parkreiner Nov 9, 2023
6c2cb3f
fix: add focus styling to icon buttons
Parkreiner Nov 9, 2023
d6bf403
fix: add focus styling to switches
Parkreiner Nov 9, 2023
97c2bbd
fix: swap outlines for box-shadows for more styling control
Parkreiner Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions site/src/theme/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,15 +427,42 @@ dark = createTheme(dark, {
MuiCheckbox: {
styleOverrides: {
root: {
/**
* Adds focus styling to checkboxes (which doesn't exist normally, for
* some reason?).
*
* The checkbox component is a root span with a checkbox input inside
* it. MUI does not allow you to use selectors like (& input) to
* target the inner checkbox (even though you can use & td to style
* tables). Tried every combination of selector possible (including
* lots of !important), and the main issue seems to be that the
* styling just never gets processed for it to get injected into the
* CSSOM.
*
* Had to settle for adding styling to the span itself (which does
* make the styling more obvious, even if there's not much room for
* customization).
*/
"&.Mui-focusVisible": {
Copy link
Member Author

@Parkreiner Parkreiner Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long comment, but trying all these selectors and seeing what exactly was happening is the reason this PR took so long. Wanted to try preventing other people from going down this rabbit hole

boxShadow: `0 0 0 2px ${colors.blue[7]}`,
},

"&.Mui-disabled": {
color: colors.gray[11],
},
},
},
},
MuiSwitch: {
defaultProps: {
color: "primary",
defaultProps: { color: "primary" },
styleOverrides: {
root: {
".Mui-focusVisible .MuiSwitch-thumb": {
// Had to thicken outline to make sure that the focus color didn't
// bleed into the thumb and was still easily-visible
boxShadow: `0 0 0 3px ${colors.blue[7]}`,
},
},
},
},
MuiAutocomplete: {
Expand Down Expand Up @@ -496,5 +523,15 @@ dark = createTheme(dark, {
},
},
},

MuiIconButton: {
styleOverrides: {
root: {
"&.Mui-focusVisible": {
boxShadow: `0 0 0 2px ${colors.blue[7]}`,
},
},
},
},
},
} as ThemeOptions);