Skip to content

chore: replace todos with issues #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2022
Merged

chore: replace todos with issues #1066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f885c7
chore: replace todos with issues
greyscaled Apr 19, 2022
ef45b8e
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
9089bb9
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
b81448b
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
68aedf7
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
305b97b
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! chore: replace todos with issues
  • Loading branch information
@greyscaled
greyscaled committed Apr 19, 2022
commit 305b97b69b05d24f96c18c2a3e61aa9b88ed1443
7 changes: 5 additions & 2 deletions site/e2e/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ interface WaitForClientSideNavigationOpts {
* @remark This is necessary in a client-side SPA world since playwright
* waitForNavigation waits for load events on the DOM (ex: after a page load
* from the server).
*
* @todo Better logging for this.
*/
export const waitForClientSideNavigation = async (page: Page, opts: WaitForClientSideNavigationOpts): Promise<void> => {
console.info(`--- waitForClientSideNavigation: start`)

await Promise.all([
waitFor(() => {
const conditions: boolean[] = []
Expand All @@ -74,9 +74,12 @@ export const waitForClientSideNavigation = async (page: Page, opts: WaitForClien
}

const unmetConditions = conditions.filter((condition) => !condition)
console.info(`--- waitForClientSideNavigation: ${unmetConditions.length} conditions not met`)

return Promise.resolve(unmetConditions.length === 0)
}),
page.waitForLoadState("networkidle"),
])

console.info(`--- waitForClientSideNavigation: done`)
}
2 changes: 0 additions & 2 deletions site/embed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,6 @@ func secureHeaders(next http.Handler) http.Handler {

// Only scripts can manipulate the dom. This prevents someone from
// naming themselves something like '<svg onload="alert(/cross-site-scripting/)" />'.
// TODO: @emyrk we need to make FE changes to enable this. We get 'TrustedHTML' and 'TrustedURL' errors
// that require FE changes to work.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1078

// "require-trusted-types-for" : []string{"'script'"},
}

Expand Down
11 changes: 3 additions & 8 deletions site/src/components/Form/FormTextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export interface FormTextFieldProps<T>
* }}
* />
*/
eventTransform?: (value: string) => unknown
eventTransform?: (value: string) => string
/**
* isPassword uses a PasswordField component when `true`; otherwise a
* TextField component is used.
Expand Down Expand Up @@ -145,13 +145,8 @@ export const FormTextField = <T,>({
}

const event = e
if (typeof eventTransform !== "undefined") {
// TODO(Grey): Asserting the type as a string here is not quite
// right in that when an input is of type="number", the value will
// be a number. Type asserting is better than conversion for this
// reason, but perhaps there's a better way to do this without any
// assertions.
event.target.value = eventTransform(e.target.value) as string
if (typeof eventTransform !== "undefined" && typeof event.target.value === "string") {
event.target.value = eventTransform(e.target.value)
}
form.handleChange(event)
}}
Expand Down
5 changes: 2 additions & 3 deletions site/src/pages/templates/[organization]/[template]/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ export const TemplatePage: React.FC = () => {
() => `/api/v2/organizations/${unsafeSWRArgument(organizationInfo).id}/templates/${templateName}`,
)

// TODO: The workspaces endpoint was recently changed, so that we can't get
// workspaces per-template. This just grabs all workspaces... and then
// later filters them to match the current template.
// This just grabs all workspaces... and then later filters them to match the
// current template.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1082

const { data: workspaces, error: workspacesError } = useSWR<Workspace[], Error>(() => `/api/v2/users/me/workspaces`)

if (organizationError) {
Expand Down