Skip to content

chore: replace todos with issues #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2022
Merged

chore: replace todos with issues #1066

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f885c7
chore: replace todos with issues
greyscaled Apr 19, 2022
ef45b8e
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
9089bb9
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
b81448b
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
68aedf7
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
305b97b
fixup! chore: replace todos with issues
greyscaled Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! chore: replace todos with issues
  • Loading branch information
@greyscaled
greyscaled committed Apr 19, 2022
commit b81448b60574fb3aab83634885adab243cad752a
3 changes: 0 additions & 3 deletions coderd/rbac/role.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ type Role struct {
Name string `json:"name"`
Site []Permission `json:"site"`
// Org is a map of orgid to permissions. We represent orgid as a string.
// TODO: Maybe switch to uuid, but tokens might need to support a "wildcard" org
// which could be a special uuid (like all 0s?)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1072

Org map[string][]Permission `json:"org"`
User []Permission `json:"user"`
}
Expand Down Expand Up @@ -49,7 +47,6 @@ var (
RoleAuditor = Role{
Name: "auditor",
Site: permissions(map[Object][]Action{
// TODO: @emyrk when audit logs are added, add back a read perm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1074

//ResourceAuditLogs: {ActionRead},
// Should be able to read user details to associate with logs.
// Without this the user-id in logs is not very helpful
Expand Down