refactor: remove usage of <Box> and sx
#10702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<Box> and sx<Box> and sx
Parkreiner
approved these changes
Nov 22, 2023
| @@ -142,6 +142,8 @@ rules: | |||
| - name: "@mui/material/Typography" | |||
| message: | |||
| "You should use the native HTML elements as span, p, h1, h2, h3..." | |||
| - name: "@mui/material/Box" | |||
| message: "You should use a <div> instead" | |||
There was a problem hiding this comment.
Small suggestion: I feel like the phrasing should push people to see if they can use a more semantic HTML element instead
There was a problem hiding this comment.
I thought about that, but I don't know how to word it in a way that fits in one line nicely. can definitely change it later!
site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10612
Use the
FCtype much more consistently throughout the codebase for declaring components and their prop typesRemove all usage of the
sxprop throughout the codebaseRemove all usage of
Boxthroughout the codebaseBreak lots of inline type definitions out into their own declarations
Make some small
cssstyles inline and break some bigger ones out intoconstdeclarations