feat: implement deprecated flag for templates to prevent new workspaces #10745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Nov 17, 2023
|
You should be able to remove deprecation even without a license, but not add it back. You should always be able to return your deployment to the pre-license state without a license. |
I can add the ability to remove deprecation then. It's just a little more difficult in the UI to have it not disabled, but then be disabled when you delete the message. I thought it was clunky in the UI 🤔 |
johnstcn
reviewed
Nov 20, 2023
johnstcn
reviewed
Nov 20, 2023
| @@ -614,6 +614,21 @@ func CreateAnotherUserMutators(t testing.TB, client *codersdk.Client, organizati | |||
| return createAnotherUserRetry(t, client, organizationID, 5, roles, mutators...) | |||
| } | |||
|
|
|||
| // AuthzUserSubject does not include the user's groups. | |||
| func AuthzUserSubject(user codersdk.User) rbac.Subject { | |||
There was a problem hiding this comment.
Yup, got tired of using AsSystemContext in all my unit tests. Figured this would be a bit better.
johnstcn
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6355
What this does
Adds a new template meta data field "deprecated" that if set blocks new workspaces from being created on that template.
Existing workspaces still function as before.
UX could be improved, but I implemented an MVP to make the deprecation noticeable on all relevant pages.
UI
Deprecate a template
Missing enterprise license
Deprecated templates remain deprecated if you lose your license. But you can no longer edit the field. I think this is better than making the template active again.
Creating a workspace
This could probably be prevented with better ux?
Templates table page
Templates page
We should show the deprecation message here. I just don't know where to put it 🤔
Workspace page