Skip to content

feat: implement deprecated flag for templates to prevent new workspaces #10745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 20, 2023
Merged

feat: implement deprecated flag for templates to prevent new workspaces #10745

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c2b05f0
feat: implement deprecated flag for templates to prevent new workspaces
Emyrk Nov 16, 2023
628b97a
Fix which user is used in unit tests
Emyrk Nov 17, 2023
0935732
Update golden files
Emyrk Nov 17, 2023
33f54f8
Add deprecated filter to template fetching
Emyrk Nov 17, 2023
f5dc43f
Add deprecated to template table
Emyrk Nov 17, 2023
4cfa940
Add deprecated notice to template page
Emyrk Nov 17, 2023
873300f
Add ui to deprecate a template
Emyrk Nov 17, 2023
576837c
add story for not entitles
Emyrk Nov 17, 2023
a9922dc
Fix stories
Emyrk Nov 17, 2023
7b647da
remove extra hook
Emyrk Nov 20, 2023
143062a
workspace alert to warning on deprecated
Emyrk Nov 20, 2023
00cc2b8
add params to getTemplates on FE
Emyrk Nov 20, 2023
cdf2945
add unit tests for agpl unsetting deprecated
Emyrk Nov 20, 2023
8db1dd6
Add more enterprise test vectors
Emyrk Nov 20, 2023
0b1c720
formatting
Emyrk Nov 20, 2023
af8226d
Merge remote-tracking branch 'origin/main' into stevenmasley/deprecat…
Emyrk Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more enterprise test vectors
  • Loading branch information
@Emyrk
Emyrk committed Nov 20, 2023
commit 8db1dd6e82b37d509b9e4ab4fe50b3c0e5fd3158
20 changes: 20 additions & 0 deletions enterprise/coderd/templates_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,18 @@ func TestTemplates(t *testing.T) {
Name: "foobar",
})
require.ErrorContains(t, err, "deprecated")

// Unset deprecated and try again
updated, err = client.UpdateTemplateMeta(ctx, template.ID, codersdk.UpdateTemplateMeta{DeprecationMessage: ptr.Ref("")})
require.NoError(t, err)
assert.False(t, updated.Deprecated)
assert.Empty(t, updated.DeprecationMessage)

_, err = client.CreateWorkspace(ctx, user.OrganizationID, codersdk.Me, codersdk.CreateWorkspaceRequest{
TemplateID: template.ID,
Name: "foobar",
})
require.NoError(t, err)
})

t.Run("BlockDisablingAutoOffWithMaxTTL", func(t *testing.T) {
Expand Down Expand Up @@ -232,6 +244,8 @@ func TestTemplates(t *testing.T) {
template, err = anotherClient.Template(ctx, template.ID)
require.NoError(t, err)
require.Equal(t, []string{"monday", "saturday"}, template.AutostartRequirement.DaysOfWeek)
require.Empty(t, template.DeprecationMessage)
require.False(t, template.Deprecated)
})

t.Run("SetInvalidAutostartRequirement", func(t *testing.T) {
Expand Down Expand Up @@ -265,6 +279,8 @@ func TestTemplates(t *testing.T) {
},
})
require.Error(t, err)
require.Empty(t, template.DeprecationMessage)
require.False(t, template.Deprecated)
})

t.Run("SetAutostopRequirement", func(t *testing.T) {
Expand Down Expand Up @@ -309,6 +325,8 @@ func TestTemplates(t *testing.T) {
require.NoError(t, err)
require.Equal(t, []string{"monday", "saturday"}, template.AutostopRequirement.DaysOfWeek)
require.EqualValues(t, 3, template.AutostopRequirement.Weeks)
require.Empty(t, template.DeprecationMessage)
require.False(t, template.Deprecated)
})

t.Run("CleanupTTLs", func(t *testing.T) {
Expand Down Expand Up @@ -666,6 +684,8 @@ func TestTemplates(t *testing.T) {
template, err = anotherClient.Template(ctx, template.ID)
require.NoError(t, err)
require.Equal(t, updatedTemplate, template)
require.Empty(t, template.DeprecationMessage)
require.False(t, template.Deprecated)
})
}

Expand Down