Skip to content

feat: add competitive advanced git functionality #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

feat: add competitive advanced git functionality #1077

merged 2 commits into from
Apr 25, 2022

Conversation

johnstcn
Copy link
Member

this is a very important feature and everybody needs it

@johnstcn johnstcn self-assigned this Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1077 (4213740) into main (c8246e3) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   66.79%   66.41%   -0.39%     
==========================================
  Files         262      261       -1     
  Lines       15653    15674      +21     
  Branches      152      152              
==========================================
- Hits        10456    10410      -46     
- Misses       4136     4191      +55     
- Partials     1061     1073      +12     
Flag Coverage Δ
unittest-go-macos-latest 53.26% <ø> (-0.34%) ⬇️
unittest-go-postgres- 65.72% <ø> (-0.24%) ⬇️
unittest-go-ubuntu-latest 55.79% <ø> (-0.08%) ⬇️
unittest-go-windows-2022 52.86% <ø> (-0.06%) ⬇️
unittest-js 67.63% <ø> (-0.34%) ⬇️
Impacted Files Coverage Δ
site/src/components/Icons/WorkspacesIcon.tsx 0.00% <0.00%> (-100.00%) ⬇️
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
provisionerd/provisionerd.go 79.70% <0.00%> (-2.21%) ⬇️
peer/conn.go 77.15% <0.00%> (-2.04%) ⬇️
cli/start.go 62.04% <0.00%> (-1.96%) ⬇️
coderd/workspaceagents.go 59.62% <0.00%> (-1.49%) ⬇️
coderd/provisionerdaemons.go 59.86% <0.00%> (-0.52%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8246e3...4213740. Read the comment docs.

return
}

args := strings.Fields(`run -it --rm git --image=index.docker.io/bitnami/git --command --restart=Never -- git`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just specify an array of args here or use a real shell arg splitter library

@johnstcn johnstcn merged commit c32a006 into main Apr 25, 2022
@johnstcn johnstcn deleted the dadjoke branch April 25, 2022 08:01
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants