Skip to content

fix: Close TURN connections to resolve flake #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix: Close TURN connections to resolve flake #1079

merged 1 commit into from
Apr 19, 2022

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs requested a review from coadler April 19, 2022 16:03
@kylecarbs kylecarbs self-assigned this Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1079 (3873404) into main (97e07a4) will increase coverage by 9.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
+ Coverage   57.34%   66.60%   +9.26%     
==========================================
  Files         262      262              
  Lines       15653    15660       +7     
  Branches      152      152              
==========================================
+ Hits         8976    10431    +1455     
+ Misses       5696     4162    -1534     
- Partials      981     1067      +86     
Flag Coverage Δ
unittest-go-macos-latest 53.47% <ø> (+0.08%) ⬆️
unittest-go-postgres- 65.79% <ø> (?)
unittest-go-ubuntu-latest 55.86% <ø> (+0.06%) ⬆️
unittest-go-windows-2022 52.87% <ø> (-0.05%) ⬇️
unittest-js 67.96% <ø> (ø)
Impacted Files Coverage Δ
codersdk/provisionerdaemons.go 59.70% <0.00%> (-5.98%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
scripts/apitypings/main.go 0.00% <0.00%> (ø)
coderd/provisionerdaemons.go 60.37% <0.00%> (+1.02%) ⬆️
coderd/workspaceagents.go 59.62% <0.00%> (+1.11%) ⬆️
coderd/templates.go 62.29% <0.00%> (+1.63%) ⬆️
peer/channel.go 86.70% <0.00%> (+1.73%) ⬆️
provisionerd/provisionerd.go 80.29% <0.00%> (+2.35%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e07a4...3873404. Read the comment docs.

@kylecarbs kylecarbs merged commit 04985a1 into main Apr 19, 2022
@kylecarbs kylecarbs deleted the turnflake branch April 19, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants