Skip to content

refactor: remove index files from components #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 19, 2022
Merged

refactor: remove index files from components #1086

merged 7 commits into from
Apr 19, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #939

@BrunoQuaresma BrunoQuaresma requested a review from presleyp as a code owner April 19, 2022 16:49
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 19, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 19, 2022 16:49
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1086 (fde57f9) into main (6c9c129) will increase coverage by 0.24%.
The diff coverage is 62.74%.

@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
+ Coverage   66.05%   66.29%   +0.24%     
==========================================
  Files         256      248       -8     
  Lines       15470    15456      -14     
  Branches      152      152              
==========================================
+ Hits        10218    10246      +28     
+ Misses       4181     4153      -28     
+ Partials     1071     1057      -14
Flag Coverage Δ
unittest-go-postgres- 65.71% <ø> (-0.19%) ⬇️
unittest-go-ubuntu-latest 55.79% <ø> (?)
unittest-js 67.32% <62.74%> (-0.26%) ⬇️
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/components/AuthAndFrame/AuthAndFrame.tsx 0.00% <0.00%> (ø)
site/src/components/CodeBlock/CodeBlock.tsx 100.00% <ø> (ø)
site/src/components/EmptyState/EmptyState.tsx 85.71% <ø> (ø)
site/src/components/ErrorSummary/ErrorSummary.tsx 66.66% <ø> (ø)
site/src/components/Form/utils.ts 85.71% <ø> (ø)
site/src/components/Header/Header.tsx 92.30% <ø> (ø)
site/src/components/Navbar/Navbar.tsx 0.00% <0.00%> (ø)
site/src/components/Preferences/Layout.tsx 0.00% <0.00%> (ø)
site/src/components/Section/Section.tsx 66.66% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9c129...fde57f9. Read the comment docs.

@code-asher code-asher mentioned this pull request Apr 19, 2022
Merged
@BrunoQuaresma BrunoQuaresma merged commit 301451b into main Apr 19, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-index branch April 19, 2022 18:20
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled approved these changes

@presleyp presleyp Awaiting requested review from presleyp

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Rename non-component files
3 participants
@BrunoQuaresma @greyscaled @misskniss