Skip to content

fix: do not allow selection of unsuccessful versions #10941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: do not allow selection of unsuccessful versions #10941

merged 3 commits into from
Nov 29, 2023

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Nov 29, 2023 •
edited
Loading

Closes #10727

@f0ssel f0ssel marked this pull request as ready for review November 29, 2023 17:52
@kylecarbs
Copy link
Member

Should we block this in the API as well?

@f0ssel
Copy link
Contributor Author

f0ssel commented Nov 29, 2023

@kylecarbs I considered it but it's the same API used for other pages that do show failed versions.

@f0ssel f0ssel merged commit d41f9f8 into main Nov 29, 2023
@f0ssel f0ssel deleted the f0ssel/filter-bad-versions branch November 29, 2023 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
@kylecarbs
Copy link
Member

Ahh, fair! Is there filtering from the API at the moment? I think if every recent one is failed this dialog would still pop up but be empty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@aslilac aslilac Awaiting requested review from aslilac

Assignees

@f0ssel f0ssel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do not show failed versions in change version drop-down
3 participants
@f0ssel @kylecarbs @BrunoQuaresma