Skip to content

fix: revert "chore(helm): gitignore and rm helm chart tarballs from vcs" #11009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: revert "chore(helm): gitignore and rm helm chart tarballs from vcs" #11009

merged 1 commit into from
Dec 4, 2023

Conversation

spikecurtis
Copy link
Contributor

Reverts #10951

PR breaks Golden File update.

$ make update-golden-files
ok  	github.com/coder/coder/v2/cli	1.788s
ok  	github.com/coder/coder/v2/helm/coder/tests	1.781s
--- FAIL: TestUpdateGoldenFiles (0.04s)
    chart_test.go:191: Using helm at "/nix/store/ddlvvqk8zfsm99yyzcdqgi6ym3zr2ikx-kubernetes-helm-3.12.2/bin/helm"
    chart_test.go:178: exec command: [/nix/store/ddlvvqk8zfsm99yyzcdqgi6ym3zr2ikx-kubernetes-helm-3.12.2/bin/helm template .. -f testdata/default_values.yaml --namespace default]
    chart_test.go:140:
        	Error Trace:	/Users/spike/repos/coder/helm/provisioner/tests/chart_test.go:140
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestUpdateGoldenFiles
        	Messages:   	failed to run `helm template -f "testdata/default_values.yaml"`
FAIL
FAIL	github.com/coder/coder/v2/helm/provisioner/tests	0.409s
FAIL
make: *** [Makefile:631: helm/provisioner/tests/testdata/.gen-golden] Error 1

@spikecurtis spikecurtis requested a review from johnstcn December 4, 2023 06:56
cdr-bot[bot]
cdr-bot bot approved these changes Dec 4, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@spikecurtis spikecurtis enabled auto-merge (squash) December 4, 2023 06:57
@spikecurtis spikecurtis changed the title Revert "chore(helm): gitignore and rm helm chart tarballs from vcs" fix: Revert "chore(helm): gitignore and rm helm chart tarballs from vcs" Dec 4, 2023
@spikecurtis spikecurtis changed the title fix: Revert "chore(helm): gitignore and rm helm chart tarballs from vcs" fix: revert "chore(helm): gitignore and rm helm chart tarballs from vcs" Dec 4, 2023
@spikecurtis spikecurtis merged commit dbadae5 into main Dec 4, 2023
@spikecurtis spikecurtis deleted the revert-10951-cj/rm-libcoder-tgz branch December 4, 2023 06:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spikecurtis