Skip to content

fix(site): e2e: use click instead of check #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(site): e2e: use click instead of check #11024

merged 1 commit into from
Dec 4, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 4, 2023

Fixes: #10989

Following the advisory in microsoft/playwright#10477, we may want to replace all check() calls with click().

@mtojek mtojek self-assigned this Dec 4, 2023
@mtojek mtojek requested a review from Parkreiner December 4, 2023 16:29
@mtojek mtojek marked this pull request as ready for review December 4, 2023 16:29
@mtojek mtojek merged commit a42b6c1 into main Dec 4, 2023
@mtojek mtojek deleted the 10989-e2e-2 branch December 4, 2023 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@Parkreiner Parkreiner Awaiting requested review from Parkreiner

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: updateWorkspace.spec.ts e2e test
2 participants
@mtojek @kylecarbs