Skip to content

fix: add additional theme colors #11313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 21, 2023
Merged

fix: add additional theme colors #11313

merged 4 commits into from
Dec 21, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Dec 21, 2023

  • Replace some "debugging" colors with actual colors for all different states/roles
  • Rearrange/reword comments to get nice language server descriptions

@aslilac aslilac requested a review from Parkreiner December 21, 2023 17:51
Parkreiner
Parkreiner approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I think that renaming the beta prop to preview makes a lot of sense, too

@aslilac aslilac merged commit e044d3b into main Dec 21, 2023
@aslilac aslilac deleted the no-more-debug-red branch December 21, 2023 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @Parkreiner