Skip to content

chore: disable failing metrics check until it can be fixed #11361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

chore: disable failing metrics check until it can be fixed #11361

merged 1 commit into from
Jan 2, 2024

Conversation

spikecurtis
Copy link
Contributor

#11175 is causing CI failures nearly every time. We are still debating the correct fix for it; in the mean time, I'm disabling the metrics check that is failing so that we don't block unrelated merges.

@spikecurtis Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

cdr-bot[bot]
cdr-bot bot approved these changes Jan 2, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@spikecurtis spikecurtis enabled auto-merge (squash) January 2, 2024 04:44
@spikecurtis spikecurtis force-pushed the spike/11175-disable-check branch from 4d79c45 to f3d8f02 Compare January 2, 2024 05:31
@spikecurtis spikecurtis merged commit 6529099 into main Jan 2, 2024
@spikecurtis spikecurtis deleted the spike/11175-disable-check branch January 2, 2024 05:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
@mafredri
Copy link
Member

mafredri commented Jan 3, 2024

@spikecurtis I see both SSH and RPTY were disabled here, do you have a link to a failure for the SSH test? AFAIK only RPTY was linked in the issue.

@spikecurtis
Copy link
Contributor Author

@spikecurtis I see both SSH and RPTY were disabled here, do you have a link to a failure for the SSH test? AFAIK only RPTY was linked in the issue.

Might have been overzealous; I assumed they were both affected by the underlying screen issue. Do we not use screen for SSH? If not that one can presumably be reenabled.

@mafredri
Copy link
Member

mafredri commented Jan 3, 2024

Might have been overzealous; I assumed they were both affected by the underlying screen issue. Do we not use screen for SSH? If not that one can presumably be reenabled.

Nope, only for RPTY and only when screen is available (and it is in CI).

No need to re-enable it for now though, I can do that at a later time when I make some other changes. Was just interested in seeing the failure if there was any. 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @mafredri