docs: update FE fetching data docs #11376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
reviewed
Jan 2, 2024
f0ssel
approved these changes
Jan 2, 2024
Parkreiner
reviewed
Jan 2, 2024
Parkreiner
approved these changes
Jan 2, 2024
Parkreiner
reviewed
Jan 2, 2024
Kira-Pilot
reviewed
Jan 2, 2024
docs/contributing/frontend.md
Outdated
| Test components without user interaction like testing if a page/component is | ||
| rendered correctly depending on some parameters, if the button is showing a | ||
| spinner, if the `loading` props are passing, etc. This should always be your | ||
| first option since it is way easier to maintain. For this, we use |
There was a problem hiding this comment.
This should always be your first option since it is way easier to maintain.
I disagree with this, tbh. I think we're running into difficulties when we use visual testing as our first line of defense. Maybe something we can chat about more during the FE variety call!
Kira-Pilot
reviewed
Jan 2, 2024
Kira-Pilot
approved these changes
Jan 2, 2024
Co-authored-by: Kira Pilot <kira@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.