Skip to content

fix: change coder start to be a no-op if workspace is started #11381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: change coder start to be a no-op if workspace is started #11381

merged 1 commit into from
Jan 3, 2024

Conversation

spikecurtis
Copy link
Contributor

Fixes #11380

@spikecurtis Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@spikecurtis spikecurtis force-pushed the spike/11380-start-no-op branch from 377187f to 0893e9f Compare January 3, 2024 07:11
johnstcn
johnstcn approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 3, 2024 •
edited
Loading

Merge activity

@spikecurtis spikecurtis merged commit 5d76210 into main Jan 3, 2024
@spikecurtis spikecurtis deleted the spike/11380-start-no-op branch January 3, 2024 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder start on an already started workspace should be a no-op
2 participants
@spikecurtis @johnstcn