Skip to content

feat: select group avatars with the emoji picker #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 3, 2024
Merged

feat: select group avatars with the emoji picker #11395

merged 6 commits into from
Jan 3, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 3, 2024 •
edited
Loading

Closes #11365

  • Use the IconField component instead of a plain TextField on the new group page
  • Refactor IconField to be lazy by default
  • Remove LazyIconField
  • Move the lazy boundary to make the loading invisible to users (this makes a multiple second difference in page loads!!)

@aslilac aslilac requested a review from BrunoQuaresma January 3, 2024 19:23
BrunoQuaresma
BrunoQuaresma approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

matifali
matifali approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aslilac 🙏

@aslilac aslilac merged commit ffa7722 into main Jan 3, 2024
@aslilac aslilac deleted the user-group-icon-picker branch January 3, 2024 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@matifali matifali matifali approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups: Add emoji/icon picker to group avatar
3 participants
@aslilac @BrunoQuaresma @matifali