fix: Increase ptytest buffer to resolve flake #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 57.54% 66.33% +8.78%
==========================================
Files 261 261
Lines 16237 16248 +11
Branches 156 156
==========================================
+ Hits 9344 10778 +1434
+ Misses 5873 4360 -1513
- Partials 1020 1110 +90
Continue to review full report at Codecov.
|
4c7ebd2 to
e9b6398
Compare
Emyrk
approved these changes
Apr 25, 2022
From investigating the following run: https://github.com/coder/coder/runs/6156348454?check_suite_focus=true It's believed that the cause is data being discarded due to the buffer filling up. This _might_ fix it, but not entirely sure.
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
From investigating the following run: https://github.com/coder/coder/runs/6156348454?check_suite_focus=true It's believed that the cause is data being discarded due to the buffer filling up. This _might_ fix it, but not entirely sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From investigating the following run:
https://github.com/coder/coder/runs/6156348454?check_suite_focus=true
It's believed that the cause is data being discarded due to the buffer
filling up. This might fix it, but not entirely sure.