Skip to content

fix: Use forward slashes on Windows for gitssh #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix: Use forward slashes on Windows for gitssh #1146

merged 2 commits into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs requested a review from f0ssel April 25, 2022 16:15
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1146 (d4691d9) into main (fccd4fa) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   66.21%   66.40%   +0.18%     
==========================================
  Files         259      259              
  Lines       16220    16221       +1     
  Branches      156      156              
==========================================
+ Hits        10740    10771      +31     
+ Misses       4367     4345      -22     
+ Partials     1113     1105       -8     
Flag Coverage Δ
unittest-go-macos-latest 53.96% <100.00%> (+0.19%) ⬆️
unittest-go-postgres- 65.93% <100.00%> (+0.11%) ⬆️
unittest-go-ubuntu-latest 56.50% <100.00%> (?)
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
agent/agent.go 63.00% <100.00%> (+0.13%) ⬆️
coderd/httpapi/httpapi.go 66.25% <0.00%> (-6.25%) ⬇️
coderd/workspaceagents.go 60.35% <0.00%> (-2.86%) ⬇️
peerbroker/proxy.go 58.72% <0.00%> (+0.58%) ⬆️
provisionerd/provisionerd.go 76.90% <0.00%> (+1.20%) ⬆️
peer/channel.go 85.54% <0.00%> (+2.31%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
peerbroker/listen.go 87.39% <0.00%> (+3.36%) ⬆️
peer/conn.go 79.94% <0.00%> (+3.80%) ⬆️
codersdk/provisionerdaemons.go 67.60% <0.00%> (+5.63%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccd4fa...d4691d9. Read the comment docs.

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 17:49
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 19:40
@kylecarbs kylecarbs merged commit 33b58a0 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the gitsshwin branch April 25, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants