feat: Use environment variables and startup script in agent #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 66.31% 66.30% -0.02%
==========================================
Files 261 257 -4
Lines 16251 16141 -110
Branches 156 156
==========================================
- Hits 10777 10702 -75
+ Misses 4362 4337 -25
+ Partials 1112 1102 -10
Continue to review full report at Codecov.
|
e54c0bd to
1155d45
Compare
coadler
reviewed
Apr 25, 2022
agent/agent.go
Outdated
Comment on lines
97
to
99
| if !a.startupScript.Load() { | ||
| // The startup script has not ran yet! | ||
| a.startupScript.Store(true) |
There was a problem hiding this comment.
This is technically racey right? I think this needs to be a CAS (compare and swap).
There was a problem hiding this comment.
You are correct. I shall fix
These values were ignored. Environment variables are applied to new sessions, and are refreshed on reconnect. This is cool because a workspace could be updated with new environment variables without requiring a complete start/stop. The startup script is only ran once regardless of changes, which feels like the expected behavior.
coadler
approved these changes
Apr 25, 2022
| return false | ||
| } | ||
| if runtime.GOOS == "windows" { | ||
| // Windows uses UTF16! 🪟🪟🪟 |
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
These values were ignored. Environment variables are applied to new sessions, and are refreshed on reconnect. This is cool because a workspace could be updated with new environment variables without requiring a complete start/stop. The startup script is only ran once regardless of changes, which feels like the expected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values were ignored. Environment variables are applied to
new sessions and are refreshed on reconnect. This is cool because
a workspace could be updated with new environment variables without
requiring a complete start/stop.
The startup script is only run once regardless of changes, which
feels like the expected behavior.