Skip to content

feat: Use environment variables and startup script in agent #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

feat: Use environment variables and startup script in agent #1147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f771652
feat: Use environment variables and startup script in agent
kylecarbs Apr 25, 2022
c665f8d
Merge branch 'main' into startup
kylecarbs Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into startup
  • Loading branch information
@kylecarbs
kylecarbs committed Apr 25, 2022
commit c665f8d673d287b07303a8e9785d37f3cad60b90
6 changes: 6 additions & 0 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ func TestAgent(t *testing.T) {

t.Run("SessionTTY", func(t *testing.T) {
t.Parallel()
if runtime.GOOS == "windows" {
// This might be our implementation, or ConPTY itself.
// It's difficult to find extensive tests for it, so
// it seems like it could be either.
t.Skip("ConPTY appears to be inconsistent on Windows.")
}
session := setupSSHSession(t, nil)
command := "bash"
if runtime.GOOS == "windows" {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.