Skip to content

ci: build a multi-arch image on each commit to main #11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jan 18, 2024
Merged

ci: build a multi-arch image on each commit to main #11544

merged 30 commits into from
Jan 18, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Jan 10, 2024 •
edited
Loading

  1. builds a multi-arch image
  2. adds a new tag ghcr.io/coder/coder-preview:latest
  3. closes ci: do not skip build check in PRs #11127

@matifali
wip
cfe0ddc 
builds a multi-arch image and closes #11127
@matifali matifali changed the title ci: builds a multi-arch main image ci: build a multi-arch main image Jan 10, 2024
@matifali matifali requested a review from johnstcn January 10, 2024 22:52
@matifali matifali marked this pull request as ready for review January 10, 2024 22:52
@matifali matifali requested a review from deansheather January 10, 2024 23:23
johnstcn
johnstcn reviewed Jan 11, 2024
View reviewed changes
johnstcn
johnstcn reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the changes to build be made a separate PR?

@matifali
Copy link
Member Author

@johnstcn The PR is mainly about changing build to build, push, and multi-arch image. I sneaked in the fix to build on the PR branch as an additional fix, as it is related.

@matifali matifali changed the title ci: build a multi-arch main image ci: build a multi-arch image on each commit to main with tag latest Jan 11, 2024
@matifali
Copy link
Member Author

@deansheather @johnstcn thoughts on renaming tag from something like :main-2.6.0-devel-7b30f2849 to :v2.6.0-devel-7b30f2849 only?

The issue is that currently when we run

make -j build/coder_"$version"_linux_{amd64,arm64,armv7}.tag

This creates images with tags :v2.6.0-devel-7b30f2849-{amd64,arm64,armv7}, which are needed to create the multi-arch manifest. So we can name our multi-arch manifest tag v2.6.0-devel-7b30f2849 instead of :main-2.6.0-devel-7b30f2849

With this chnage, we will not have a mix of :main-2.6.0-devel-7b30f2849 and :v2.6.0-devel-7b30f2849-{amd64,arm64,armv7} tags.

Please look at the screenshot for the tags' name notation mixing. We can also update Makefile to allow the creation of custom tags for arch images so that they have 'main' appended to their name.

image

deansheather
deansheather reviewed Jan 16, 2024
View reviewed changes
@matifali matifali requested a review from deansheather January 17, 2024 14:21
@matifali matifali changed the title ci: build a multi-arch image on each commit to main with tag latest ci: build a multi-arch image on each commit to main Jan 17, 2024
@matifali matifali requested a review from johnstcn January 17, 2024 14:23
@matifali matifali mentioned this pull request Jan 17, 2024
Closed
deansheather
deansheather approved these changes Jan 17, 2024
View reviewed changes
johnstcn
johnstcn approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved pending Dean's outstanding items.

@matifali matifali enabled auto-merge (squash) January 18, 2024 10:50
@matifali matifali merged commit 1ea70ba into main Jan 18, 2024
@matifali matifali deleted the multi-arch-main branch January 18, 2024 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: do not skip build check in PRs
3 participants
@matifali @johnstcn @deansheather