-
Notifications
You must be signed in to change notification settings - Fork 888
ci: build a multi-arch main image #11668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we should leave it how it is. We want to ship the same binary everywhere, so it'd be weird to rebuild it in the Docker image compared to the one we ship as a raw binary on github releases. |
@deansheather, which one do you prefer? #11544 or this one? |
@matifali The other one, you shouldn't need depot to build these. We only use depot to build the "base" image, which is built on every release and on a weekly basis and pushed to the base repo. The reason we need depot to build that is because it has |
@deansheather I understand, but our current approach requires pushing individual arch images to the registry and then pulling those back, creating a manifest, and pushing the manifest. Depot allows removing all that and makes it super easy to push multi-arch images. |
After discussing with @deansheather, I am closing in favor of #11544. We do not benefit from the depot.dev as our multi-arch |
2nd attempt at #11544
Additionally, we can move the coder build to Dockerfile and build with dpot.dev 16 core 32 GB builder.