feat(cli/ssh): allow multiple remote forwards and allow missing local file #11648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e66663 to
c2dea4a
Compare
spikecurtis
approved these changes
Jan 18, 2024
8da5d2c to
f752bb6
Compare
f752bb6 to
f99f490
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #11631 I found myself needing the ability to do multiple remote forwards to compare the behavior between our client and OpenSSH. Created a PR for this since I think it's a useful addition.
Similar to OpenSSH, we no longer require the presence of the local file. Its presence is only relevant at exactly the moment someone tries to connect to it. Likewise, we don't enforced the presence at runtime, so to achieve this you'd have to fool the SSH command during init, and then you can do whatever you want with the socket afterwards.