Skip to content

feat: check agent API version on connection #11696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat: check agent API version on connection #11696

merged 1 commit into from
Jan 23, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 19, 2024 •
edited
Loading

fixes #10531

Adds a check for version on connection to the Agent API websocket endpoint. This is primarily for future-proofing, so that up-level agents get a sensible error if they connect to a back-level Coderd.

It also refactors the location of the CurrentVersion variables, to be part of the proto packages, since the versions refer to the APIs defined therein.

This was referenced Jan 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Jan 19, 2024
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review January 19, 2024 08:24
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from c7f73d4 to 135bd48 Compare January 19, 2024 12:36
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 3469608 to f56be8e Compare January 19, 2024 12:36
@spikecurtis spikecurtis mentioned this pull request Jan 19, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 135bd48 to ecef2a9 Compare January 22, 2024 06:58
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from f56be8e to 24a943c Compare January 22, 2024 06:59
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from ecef2a9 to 0b0b1a4 Compare January 22, 2024 08:05
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 24a943c to 16322d1 Compare January 22, 2024 08:05
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 0b0b1a4 to 7a301f1 Compare January 22, 2024 11:18
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 16322d1 to c91b1c0 Compare January 22, 2024 11:18
@spikecurtis spikecurtis mentioned this pull request Jan 22, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 7a301f1 to 0e38400 Compare January 22, 2024 11:30
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from c91b1c0 to 671a2e9 Compare January 22, 2024 11:30
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 0e38400 to 35d99a8 Compare January 22, 2024 12:47
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 671a2e9 to 5fa6879 Compare January 22, 2024 12:47
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 35d99a8 to 66da7c6 Compare January 22, 2024 12:48
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 5fa6879 to 8ad2024 Compare January 22, 2024 12:48
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 66da7c6 to 62e95de Compare January 23, 2024 05:52
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 8ad2024 to d7a1794 Compare January 23, 2024 05:52
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 62e95de to 5695841 Compare January 23, 2024 09:09
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from d7a1794 to 59e8c2f Compare January 23, 2024 09:09
Base automatically changed from spike/10533-servertailnet-set-lost to main January 23, 2024 09:17
@spikecurtis spikecurtis force-pushed the spike/10531-check-agent-api-version branch from 59e8c2f to 8cbda21 Compare January 23, 2024 10:19
This was referenced Jan 23, 2024
Merged
Merged
Merged
@spikecurtis spikecurtis merged commit 3e0e7f8 into main Jan 23, 2024
@spikecurtis spikecurtis deleted the spike/10531-check-agent-api-version branch January 23, 2024 10:27
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Agent API v2 websocket endpoint
2 participants
@spikecurtis @deansheather