Skip to content

feat: change codersdk to use tailnet v2 for DERPMap updates #11736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat: change codersdk to use tailnet v2 for DERPMap updates #11736

merged 1 commit into from
Jan 29, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 22, 2024 •
edited
Loading

fixes #10533

refactors codersdk workspace agent dialer to use a single websocket connection to the tailnet v2 API for both coordination and DERPMap updates, rather than separate websockets (and the v1 API for DERPMaps).

This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Jan 22, 2024
Merged
Merged
@spikecurtis spikecurtis requested review from coadler and deansheather and removed request for coadler January 22, 2024 11:19
@spikecurtis spikecurtis marked this pull request as ready for review January 22, 2024 11:20
@spikecurtis spikecurtis force-pushed the spike/10534-agent-derp-maps branch from 924c97f to 5a7c1aa Compare January 22, 2024 11:22
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 63bc699 to 19a4ef4 Compare January 22, 2024 11:23
@spikecurtis spikecurtis changed the title feat: changes codersdk to use tailnet v2 for DERPMap updates feat: change codersdk to use tailnet v2 for DERPMap updates Jan 22, 2024
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from e61389c to c7097e9 Compare January 23, 2024 05:52
@spikecurtis spikecurtis force-pushed the spike/10534-agent-derp-maps branch from db15895 to 081584f Compare January 23, 2024 09:09
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from c7097e9 to e00d517 Compare January 23, 2024 09:09
@spikecurtis spikecurtis force-pushed the spike/10534-agent-derp-maps branch from 081584f to 05d21b1 Compare January 23, 2024 10:19
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from e00d517 to ffbd488 Compare January 23, 2024 10:19
This was referenced Jan 23, 2024
Merged
Merged
Merged
@spikecurtis spikecurtis force-pushed the spike/10534-agent-derp-maps branch from 05d21b1 to cc0751d Compare January 23, 2024 10:28
Base automatically changed from spike/10534-agent-derp-maps to main January 23, 2024 10:42
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from ffbd488 to 05b6c81 Compare January 23, 2024 18:25
@spikecurtis spikecurtis changed the base branch from main to spike/fix-derp-spam January 24, 2024 10:26
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 05b6c81 to 7218a92 Compare January 24, 2024 10:26
@spikecurtis spikecurtis mentioned this pull request Jan 24, 2024
Merged
Base automatically changed from spike/fix-derp-spam to main January 24, 2024 12:27
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 7218a92 to 7297387 Compare January 24, 2024 12:55
@spikecurtis spikecurtis mentioned this pull request Jan 24, 2024
Merged
@spikecurtis spikecurtis requested a review from coadler January 25, 2024 10:49
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 7297387 to 280a501 Compare January 25, 2024 11:23
@spikecurtis spikecurtis mentioned this pull request Jan 25, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch 2 times, most recently from bfbb557 to 5abcdd4 Compare January 26, 2024 09:24
This was referenced Jan 26, 2024
Merged
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 5abcdd4 to 0a384f2 Compare January 26, 2024 15:27
@spikecurtis spikecurtis merged commit f9fdd44 into main Jan 29, 2024
@spikecurtis spikecurtis deleted the spike/10533-codersdk-derp-map branch January 29, 2024 07:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Tailnet API v2 support in tailnet.Conn
2 participants
@spikecurtis @coadler