Skip to content

feat(scaletest/templates): add support for concurrent scenarios #11753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jan 30, 2024
Merged

feat(scaletest/templates): add support for concurrent scenarios #11753

merged 18 commits into from
Jan 30, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jan 22, 2024 •
edited
Loading

Fixes #10794

This PR includes some other fixes as well.

@johnstcn
Copy link
Member

johnstcn commented Jan 22, 2024 •
edited
Loading

It might be also good to suspend the HelmRelease manifests so that Flux doesn't trigger a deployment during scale testing.

You can do this by setting spec.suspend: true in the manifest YAML (or JSON, as you wish), and setting them back to false afterwards.

$ kubectl get helmrelease -n coder-big big -o yaml
apiVersion: helm.toolkit.fluxcd.io/v2beta2
kind: HelmRelease
metadata:
  [...]
  name: big
  namespace: coder-big
spec:
  [...]
  suspend: true
  [...]
status:
  [...]

Alternatively, you can just use the flux CLI and run flux (suspend|resume) helmrelease <release_name>

@mafredri mafredri marked this pull request as ready for review January 29, 2024 17:14
@mafredri mafredri requested review from johnstcn and mtojek January 29, 2024 17:14
mtojek
mtojek approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a bit hard for me to go through this review due to Bash syntax, so please assume this to be a high-level review 👍

scaletest/templates/scaletest-runner/scripts/run.sh
# we're creating a lot of workspaces at once and some of them may fail
# due to network issues or other transient errors.
coder exp scaletest create-workspaces \
--retry 5 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this must be ignored&retried, maybe we should identify and fix problems in a different way, even provisioning workspaces slower?

Anyway, consider it to be a side thought.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to ensure terraform registry is cached locally, once we know workspace builds don't use any external networking, we could potentially disable the retry, if we want. 👍🏻

@mafredri mafredri merged commit 83eea2d into main Jan 30, 2024
@mafredri mafredri deleted the mafredri/feat-scaletest-add-load-concurrency-and-percentages branch January 30, 2024 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the workload for the coder scaletest command to be split up
3 participants
@mafredri @johnstcn @mtojek