Skip to content

fix(coderd): alter return signature of convertWorkspace, add check for requesterID #11796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(coderd): alter return signature of convertWorkspace, add check for requesterID #11796

merged 1 commit into from
Jan 24, 2024

Conversation

johnstcn
Copy link
Member

From comment in #11791 (comment): adds a check to convertWorkspace that requesterID is not the nil UUID.

@johnstcn johnstcn self-assigned this Jan 24, 2024
@johnstcn johnstcn marked this pull request as ready for review January 24, 2024 13:58
@johnstcn johnstcn requested a review from mtojek January 24, 2024 13:58
mtojek
mtojek approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johnstcn johnstcn merged commit 4616ccf into main Jan 24, 2024
@johnstcn johnstcn deleted the cj/convert-workspaces-requester-id branch January 24, 2024 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek