refactor(site): improve parameters field #11802
Conversation
| This decision was made because rich parameter inputs are more visually dense than standard text fields. | ||
| */} | ||
| <div css={{ display: "flex", flexDirection: "column", gap: 36 }}> | ||
| {parameters.map((parameter, index) => { |
There was a problem hiding this comment.
NIT: I might lift this function outside of the JSX.
There was a problem hiding this comment.
Which function? The map?
There was a problem hiding this comment.
the callback that the map takes
There was a problem hiding this comment.
I think it is quite normal in react codebases but any specific concern?
There was a problem hiding this comment.
I feel like it lowers general readability because its a longer callback that defines multiple variables, but no strong concerns!
There was a problem hiding this comment.
I see! But in this case, we would have to pass 3+ arguments to the function so I'm not sure if extracting it to a new function or component would improve that much but I can understand the reasoning.
|
Related to #11742 |
Before:
After:
