feat: use Agent v2 API for Service Banner #11806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
cfe6dcc to
6f243f6
Compare
368f754 to
4dc08bc
Compare
4dc08bc to
6e7e25f
Compare
6f243f6 to
a85394d
Compare
6e7e25f to
c4af306
Compare
a85394d to
1c21905
Compare
c4af306 to
4579eae
Compare
This was referenced Jan 26, 2024
1c21905 to
98ab55e
Compare
4579eae to
7961d48
Compare
98ab55e to
174664c
Compare
7961d48 to
04cdbc1
Compare
174664c to
385e74a
Compare
04cdbc1 to
320f232
Compare
385e74a to
43a1c9e
Compare
320f232 to
492a7d4
Compare
deansheather
approved these changes
Jan 29, 2024
| @@ -254,3 +246,73 @@ type closeFunc func() error | |||
| func (c closeFunc) Close() error { | |||
| return c() | |||
| } | |||
|
|
|||
| type FakeAgentAPI struct { | |||
There was a problem hiding this comment.
I could generate it as a Mock, but that won't fit as easily into our existing tests.
Base automatically changed from
spike/10534-agentapi-appearance-fetcher
to
main
January 29, 2024 17:22
492a7d4 to
a401924
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent uses the v2 API for the service banner, rather than the v1 HTTP API.
One of several for #10534