chore: move proto to sdk conversion to agentsdk #11831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
This was referenced Jan 26, 2024
6fcd156 to
1f928bd
Compare
d5955e3 to
531707c
Compare
1f928bd to
395f862
Compare
531707c to
60b8ac5
Compare
395f862 to
5798ab2
Compare
60b8ac5 to
669395f
Compare
5798ab2 to
903844a
Compare
669395f to
f0467b1
Compare
903844a to
fa421d2
Compare
f0467b1 to
9233e88
Compare
deansheather
approved these changes
Jan 29, 2024
fa421d2 to
557df04
Compare
9233e88 to
a0f3144
Compare
557df04 to
1444bef
Compare
a0f3144 to
134b25d
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agentsdkdepends onagent/protobecause it needs to get the version to dial.Therefore, the conversion routines need to live in
agentsdkso that we can convert to and from the Manifest.I briefly considered refactoring the agent to only reference
proto.Manifest, but decided against it because we might have multiple protocol versions in the future, its useful to have a protocol-independent data structure.