Skip to content

feat: add port-sharing backend #11939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 82 commits into from
Feb 13, 2024
Merged

feat: add port-sharing backend #11939

merged 82 commits into from
Feb 13, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jan 30, 2024 •
edited
Loading

Closes #11845
Closes #11846
Closes #11849
Closes #11850
Closes #11854

I'm doing these together so I can deliver a basic API that respects both AGPL and Enterprise.

AGPL

  • Allow all levels of port sharing

Enterprise

  • Templates now have a configuration for max port sharing level, uses the template metadata edit API

@f0ssel f0ssel force-pushed the f0ssel/port-sharing-1 branch from 15fdad8 to ea91c1b Compare January 30, 2024 19:34
@f0ssel f0ssel changed the title feat: add post port-sharing level feat: add port-sharing level Jan 30, 2024
@f0ssel f0ssel force-pushed the f0ssel/port-sharing-1 branch from 9b5d1e6 to 0cf4c02 Compare February 5, 2024 15:29
@f0ssel f0ssel marked this pull request as ready for review February 5, 2024 20:10
@f0ssel f0ssel requested review from deansheather and sreya February 5, 2024 20:10
deansheather
deansheather reviewed Feb 7, 2024
View reviewed changes
deansheather
deansheather reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs integration tests, you can add them to the apptest package

@f0ssel f0ssel force-pushed the f0ssel/port-sharing-1 branch from 4cbd6e4 to 1a2bc73 Compare February 7, 2024 22:04
@deansheather deansheather self-requested a review February 9, 2024 15:42
deansheather
deansheather reviewed Feb 9, 2024
View reviewed changes
deansheather
deansheather reviewed Feb 10, 2024
View reviewed changes
@f0ssel f0ssel requested a review from deansheather February 12, 2024 14:43
@f0ssel f0ssel merged commit 3ab3a62 into main Feb 13, 2024
@f0ssel f0ssel deleted the f0ssel/port-sharing-1 branch February 13, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@f0ssel f0ssel

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@f0ssel @deansheather