feat: add custom error message on signups disabled page #11959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mtojek. I think having a minimal markdown that can render links or make them clickable should be done. |
|
Alright, I'm going to expand it! |
|
@matifali Ok, please let me know your thoughts! Markdown can be rendered now. |
johnstcn
reviewed
Feb 1, 2024
There was a problem hiding this comment.
The only possible concern here is a bad actor injecting malicious HTML into the page. However in order to do this they have to get access to modify Coder's deployment values, and if this is the case then the deployment should already be considered compromised.
However, it's no harm to add some tests to validate that basic code injection is handled properly.
johnstcn
approved these changes
Feb 1, 2024
matifali
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11679
Once Coder administrators sets this custom error message:
It will be rendered as follows:
