Skip to content

fix: use dark background in terminal, even when a light theme is selected #12004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: use dark background in terminal, even when a light theme is selected #12004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: use dark background in terminal, even when a light theme is sele… 
…cted.
  • Loading branch information
@aslilac
aslilac committed Feb 2, 2024
commit 571d95ebc5559d34926f7dc30816c3393187ac51
7 changes: 5 additions & 2 deletions site/src/pages/TerminalPage/TerminalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ export const Language = {
};

const TerminalPage: FC = () => {
const theme = useTheme();
// Maybe one day we'll support a light themed terminal, but terminal coloring
// is notably a pain because of assumptions certain programs might make about your
// background color.
const theme = themes.dark;
const navigate = useNavigate();
const { proxy, proxyLatencies } = useProxy();
const params = useParams() as { username: string; workspace: string };
Expand Down Expand Up @@ -296,7 +299,7 @@ const TerminalPage: FC = () => {
]);

return (
<ThemeOverride theme={themes.dark}>
<ThemeOverride theme={theme}>
<Helmet>
<title>
{workspace.data
Expand Down