feat: add support for optional external auth providers #12021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b83538b to
179adae
Compare
spikecurtis
reviewed
Feb 15, 2024
|
Regarding this UX, should we revert to the old UI? The "Connect" button with "Optional" and then also presumably a "Skip" feels like a lot. |
it sounds like everyone is in favor of a revert. the screenshot is of some very very placeholder coder for testing that isn't even in this pr. the frontend stuff will be a separate pr. |
johnstcn
reviewed
Feb 16, 2024
coderd/database/migrations/000194_external_auth_providers_jsonb.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
heads-up: just before you merge, double-check the latest migration number on main
aslilac
commented
Feb 20, 2024
johnstcn
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(screenshot includes frontend changes that will be landing in a separate pull request, because this one is already big enough 😄)
Part of #10109
external_auth_providerscolumn in the database, in order to be able to contain metadata about providers, such as settings/attributes defined in Terraform.external_auth_provider.optionalin the Terraform provisioner and provisionerdoptionaltoTemplateVersionExternalAuth/templateversions/{templateversion}/external-authTODO
proto.CurrentVersion? there are some tests failing because of this, and I'm not really sure what to do about itoptionalwould just silently disappear