fix: make status type on filter query

coder · BrunoQuaresma · Apr 29, 2022 · Apr 28, 2022 · Apr 28, 2022 · Apr 28, 2022
commit 3f25967cda26e0a51e246957c7287f38f0c8fde0
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -229,7 +229,7 @@ func (q *fakeQuerier) GetUsers(_ context.Context, params database.GetUsersParams
 	if params.Status != "" {
 		usersFilteredByStatus := make([]database.User, 0, len(users))
 		for i, user := range users {
-			if user.Status == params.Status {
+			if params.Status == string(user.Status) {
 				usersFilteredByStatus = append(usersFilteredByStatus, users[i])
 			}
 		}

diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/users.sql b/coderd/database/queries/users.sql
@@ -87,7 +87,7 @@ WHERE
 	END
 	-- Filter by status
 	AND CASE
-		WHEN @status :: user_status != '' THEN (
+		WHEN @status :: text != '' THEN (
 			status = @status
 		)
 		ELSE true

diff --git a/coderd/users.go b/coderd/users.go
@@ -137,7 +137,7 @@ func (api *api) users(rw http.ResponseWriter, r *http.Request) {
 		OffsetOpt: int32(offset),
 		LimitOpt:  int32(pageLimit),
 		Search:    searchName,
-		Status:    database.UserStatus(statusFilter),
+		Status:    statusFilter,
 	})
 
 	if err != nil {