Skip to content

feat: add filter by status on GET /users #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 29, 2022
Merged

feat: add filter by status on GET /users #1206

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
08fa3a7
feat: add filter by status on GET /users
BrunoQuaresma Apr 28, 2022
39b1dfb
fix: generate TS types
BrunoQuaresma Apr 28, 2022
f4465d0
fix: fix tests
BrunoQuaresma Apr 28, 2022
9a5a74b
fix: status filter o users sql
BrunoQuaresma Apr 28, 2022
83f29c7
fix: fix query and add comments
BrunoQuaresma Apr 28, 2022
3f25967
fix: make status type on filter query
BrunoQuaresma Apr 28, 2022
677cb6f
fix: add comment about @status being a text
BrunoQuaresma Apr 28, 2022
300c246
chore: Merge branch 'main' of github.com:coder/coder into bq/return-o…
BrunoQuaresma Apr 28, 2022
18297ea
chore: Update coderd/users_test.go
BrunoQuaresma Apr 28, 2022
b78e7cb
chore: Merge branch 'main' of github.com:coder/coder into bq/return-o…
BrunoQuaresma Apr 28, 2022
e9dd427
fix: cast status as user_status inside of the when
BrunoQuaresma Apr 28, 2022
4a7ffd6
refactor: move status filter
BrunoQuaresma Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add comment about @status being a text
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 28, 2022
commit 677cb6f9e958aa441cb0c7ff230b15b6690d03b0
2 changes: 2 additions & 0 deletions coderd/database/queries/users.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ WHERE
END
-- Filter by status
AND CASE
-- @status needs to be a text because it can be empty, If it was
-- user_status enum, it would not.
WHEN @status :: text != '' THEN (
status = @status
)
Expand Down