feat: add port sharing frontend #12119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma I'm going to continue working on adding tests for this feature, but I think the feature is in a good spot to get an initial review. Thanks |
|
Minor comment related to the template settings design: I think the select, label, and text helper should look like the "Days with required stop" field: Wdyt? |
BrunoQuaresma
approved these changes
Feb 20, 2024
Totally, I think I was looking for a good example to copy, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following improvements can be made in future PRs:
Template Setting:
PortsPopover:
Template Max Sharing Level Owner:
Template Max Sharing Level Authenticated:
Experiment Not Enabled:
