Skip to content

feat: add port sharing frontend #12119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 20, 2024
Merged

feat: add port sharing frontend #12119

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2cead42
init
f0ssel Jan 24, 2024
fb23e77
add query:
f0ssel Feb 8, 2024
c9c18d1
style
f0ssel Feb 8, 2024
37009c7
add filter
f0ssel Feb 8, 2024
7839a2c
Add mutations
f0ssel Feb 9, 2024
174214a
get form working
f0ssel Feb 14, 2024
43be95e
fix template settings input
f0ssel Feb 15, 2024
9f267ec
storybook
f0ssel Feb 16, 2024
ace1c1a
make fmt
f0ssel Feb 16, 2024
9deb05c
filter shared ports correctly
f0ssel Feb 16, 2024
267405b
work on form submission
f0ssel Feb 20, 2024
1baa1a4
remove export
f0ssel Feb 20, 2024
2e10ecc
get form to behave
f0ssel Feb 20, 2024
74a65d3
fmt
f0ssel Feb 20, 2024
d3927f0
Add basic test
f0ssel Feb 20, 2024
a5dbe20
fmt
f0ssel Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style
  • Loading branch information
@f0ssel
f0ssel committed Feb 13, 2024
commit c9c18d1a5b60924f6eb167bf3d6565d01f9dc03a
124 changes: 38 additions & 86 deletions site/src/modules/resources/PortForwardButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ import TextField from "@mui/material/TextField";
import SensorsIcon from "@mui/icons-material/Sensors";
import LockIcon from "@mui/icons-material/Lock";
import LockOpenIcon from "@mui/icons-material/LockOpen";
import IconButton from "@mui/material/IconButton";
import CloseIcon from "@mui/icons-material/Close";
import Grid from "@mui/material/Grid";

export interface PortForwardButtonProps {
host: string;
Expand Down Expand Up @@ -215,8 +218,8 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
<Stack
key={port.port}
direction="row"
justifyContent="space-between"
alignItems="center"
justifyContent="space-between"
>
<Link
underline="none"
Expand All @@ -228,6 +231,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
<SensorsIcon css={{ width: 14, height: 14 }} />
{label}
</Link>
<Stack direction="row" gap={2} justifyContent="flex-end" alignItems="center">
<Link
underline="none"
css={styles.portLink}
Expand All @@ -240,6 +244,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
<Button size="small" variant="text">
Share
</Button>
</Stack>
</Stack>
);
})}
Expand All @@ -252,9 +257,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
>
<HelpTooltipTitle>Shared Ports</HelpTooltipTitle>
<HelpTooltipText css={{ color: theme.palette.text.secondary }}>
{listeningPorts?.length === 0
? "No ports are shared."
: "Ports can be shared with other Coder users or with the public."}
Ports can be shared with other Coder users or with the public.
</HelpTooltipText>
<div>
{sharedPorts?.map((share) => {
Expand Down Expand Up @@ -287,27 +290,36 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
)}
{label}
</Link>
<Stack direction="row" gap={1}>
<FormControl size="small">
<Select
sx={{
boxShadow: "none",
".MuiOutlinedInput-notchedOutline": { border: 0 },
"&.MuiOutlinedInput-root:hover .MuiOutlinedInput-notchedOutline":
{
border: 0,
},
"&.MuiOutlinedInput-root.Mui-focused .MuiOutlinedInput-notchedOutline":
{
border: 0,
},
}}
value={share.share_level}
>
<MenuItem value="Authenticated">Authenticated</MenuItem>
<MenuItem value="Public">Public</MenuItem>
</Select>
</FormControl>
<Stack direction="row" justifyContent="flex-end">
<FormControl size="small">
<Select
sx={{
boxShadow: "none",
".MuiOutlinedInput-notchedOutline": { border: 0 },
"&.MuiOutlinedInput-root:hover .MuiOutlinedInput-notchedOutline":
{
border: 0,
},
"&.MuiOutlinedInput-root.Mui-focused .MuiOutlinedInput-notchedOutline":
{
border: 0,
},
}}
value={share.share_level}
>
<MenuItem value="authenticated">Authenticated</MenuItem>
<MenuItem value="public">Public</MenuItem>
</Select>
</FormControl>
<IconButton>
<CloseIcon
css={{
width: 14,
height: 14,
color: theme.palette.text.primary,
}}
/>
</IconButton>
</Stack>
</Stack>
);
Expand All @@ -328,69 +340,9 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
<MenuItem value="Public">Public</MenuItem>
</Select>
</FormControl>
<Button variant="contained">Add Shared Port</Button>
<Button variant="contained">Share Port</Button>
</Stack>
</div>

{/* <div css={{ padding: 20 }}>
<HelpTooltipTitle>Forward port</HelpTooltipTitle>
<HelpTooltipText css={{ color: theme.palette.text.secondary }}>
Access ports running on the agent:
</HelpTooltipText>

<form
css={styles.newPortForm}
onSubmit={(e) => {
e.preventDefault();
const formData = new FormData(e.currentTarget);
const port = Number(formData.get("portNumber"));
const url = portForwardURL(
host,
port,
agent.name,
workspaceName,
username,
);
window.open(url, "_blank");
}}
>
<input
aria-label="Port number"
name="portNumber"
type="number"
placeholder="Type a port number..."
min={0}
max={65535}
required
css={styles.newPortInput}
/>
<Button
type="submit"
size="small"
variant="text"
css={{
paddingLeft: 12,
paddingRight: 12,
minWidth: 0,
}}
>
<OpenInNewOutlined
css={{
flexShrink: 0,
width: 14,
height: 14,
color: theme.palette.text.primary,
}}
/>
</Button>
</form>

<HelpTooltipLinksGroup>
<HelpTooltipLink href={docs("/networking/port-forwarding#dashboard")}>
Learn more
</HelpTooltipLink>
</HelpTooltipLinksGroup>
</div> */}
</>
);
};
Expand Down