chore: move LogSender to agentsdk #12158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
mafredri
reviewed
Feb 15, 2024
codersdk/agentsdk/logs.go
Outdated
| pl, err := ProtoFromLog(log) | ||
| if err != nil { | ||
| logger.Critical(context.Background(), "failed to convert log", slog.Error(err)) | ||
| return |
There was a problem hiding this comment.
Echo from review of previous PR:
Suggested change
| return | |
| continue |
There was a problem hiding this comment.
I changed this to drop **Coder Internal Error**: Failed to convert log into the logs stream, so it's super obvious there is a big problem.
2a2203e to
900e32a
Compare
mafredri
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the LogSender to agentsdk and deprecates LogsSender based on the v1 API.