-
Notifications
You must be signed in to change notification settings - Fork 887
chore: reimplement activity status and autostop improvements #12175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71ee402
to
f83f847
Compare
site/src/hooks/useTime.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna talk with Michael about this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE code looks good. Just left minor considerations.
Users have been requesting that we not show the warning or schedule controls when a workspace is active, but I felt it was important to still let them access that information/functionality if necessary, so the icon is acting as a button. If you click it, it "expands" into the full thing with stuff to the right. Plus the icon indicates that the workspace still has scheduling controls enabled. Happy to iterate more on this in the future, but I'm a lot happier with this version than any of my previous iterations, and would rather do any further improvements as follow-ups, with more discussion about how exactly this should behave, rather than just continuing to free-hand the design. |
Closes #11710
Closes #11694
Closes #12064
Based on #11987
Revised changes to the
WorkspaceScheduleControls
, now with less jankWith

deadline
andmax_deadline
soonWith

deadline
and amax_deadline
at least two hours away...and now you can click to get at the controls if you need them for some reason, even when "connected"

If you're not "connected", it looks basically the same as before, but with better/more descriptive tooltips