Skip to content

chore: reimplement activity status and autostop improvements #12175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Feb 15, 2024

Closes #11710
Closes #11694
Closes #12064

Based on #11987

Revised changes to the WorkspaceScheduleControls, now with less jank

With deadline and max_deadline soon
Screenshot 2024-02-26 at 12 30 32 PM

With deadline and a max_deadline at least two hours away
Screenshot 2024-02-26 at 12 30 52 PM

...and now you can click to get at the controls if you need them for some reason, even when "connected"
Screenshot 2024-02-26 at 12 58 36 PM

If you're not "connected", it looks basically the same as before, but with better/more descriptive tooltips

@aslilac aslilac changed the title chore: reland activity status and autostop improvements chore: reimplement activity status and autostop improvements Feb 20, 2024
@aslilac aslilac force-pushed the reland-activity-and-autostop-changes branch from 71ee402 to f83f847 Compare February 26, 2024 21:44
@aslilac aslilac marked this pull request as ready for review February 26, 2024 21:45
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna talk with Michael about this!

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks good. Just left minor considerations.

@BrunoQuaresma
Copy link
Collaborator

With deadline and a max_deadline at least two hours away
image

I found confusing having the clock icon without any other info on the right. It is not following the same pattern in the top bar.

@aslilac
Copy link
Member Author

aslilac commented Feb 27, 2024

I found confusing having the clock icon without any other info on the right. It is not following the same pattern in the top bar.

Users have been requesting that we not show the warning or schedule controls when a workspace is active, but I felt it was important to still let them access that information/functionality if necessary, so the icon is acting as a button. If you click it, it "expands" into the full thing with stuff to the right. Plus the icon indicates that the workspace still has scheduling controls enabled.

Happy to iterate more on this in the future, but I'm a lot happier with this version than any of my previous iterations, and would rather do any further improvements as follow-ups, with more discussion about how exactly this should behave, rather than just continuing to free-hand the design.

@aslilac aslilac merged commit b2413a5 into main Feb 27, 2024
@aslilac aslilac deleted the reland-activity-and-autostop-changes branch February 27, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants