Skip to content

fix: improve clipboard support on HTTP connections and older browsers #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: improve clipboard support on HTTP connections and older browsers #12178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1917bc
fix: add future-proofing for clipboard copies on http connections
Parkreiner Feb 15, 2024
a041dbd
docs: clean up comment formatting
Parkreiner Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: clean up comment formatting
  • Loading branch information
@Parkreiner
Parkreiner committed Feb 15, 2024
commit a041dbd6acef8efa792560005264fe10fa25fcb5
3 changes: 0 additions & 3 deletions site/src/hooks/useClipboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ function simulateClipboardWrite(textToCopy: string): boolean {
* that always returns false. You cannot make any assumptions about how its
* core functionality will be removed.
*
* The nullish operators should not be removed, despite what any IDEs might
* say.
*
* @see {@link https://developer.mozilla.org/en-US/docs/Web/API/Clipboard}
*/
let isCopied: boolean;
Expand Down