fix(helm)!: remove prometheus-http port declaration from coderd service spec #12214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/s/probably/definitely |
spikecurtis
reviewed
Feb 20, 2024
spikecurtis
reviewed
Feb 20, 2024
deansheather
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
prometheus-httpport entirely from the coder service specification (originally added in #10448). It also removes the Helm valuecoder.service.prometheusNodePort.Rationale: some cloud providers will helpfully expose all ports on a
LoadBalancerservice for you. The net effect of this is that settingCODER_PROMETHEUS_ENABLEwill end up exposing port 2112 on your coderd service to the internet, which is likely undesired behaviour.cc @bpmct for visibility, this will need to be called out in release notes