Skip to content

fix(helm)!: remove prometheus-http port declaration from coderd service spec #12214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2024
+22 −34
Merged

fix(helm)!: remove prometheus-http port declaration from coderd service spec #12214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac6e439
fix!(helm): remove prometheus-http port declaration from coderd servi…
johnstcn Feb 19, 2024
973143a
update docs
johnstcn Feb 19, 2024
d66bd75
remove coder.service.prometheusNodePort
johnstcn Feb 20, 2024
d9a275a
add example headless service
johnstcn Feb 20, 2024
ad02adc
make fmt
johnstcn Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions helm/coder/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,25 +28,6 @@ spec:
nodePort: {{ .Values.coder.service.httpsNodePort }}
{{ end }}
{{- end }}
{{- range .Values.coder.env }}
{{- if eq .name "CODER_PROMETHEUS_ENABLE" }}
{{/*
This sadly has to be nested to avoid evaluating the second part
of the condition too early and potentially getting type errors if
the value is not a string (like a `valueFrom`). We do not support
`valueFrom` for this env var specifically.
*/}}
{{- if eq .value "true" }}
- name: "prometheus-http"
port: 2112
targetPort: "prometheus-http"
protocol: TCP
{{ if eq $.Values.coder.service.type "NodePort" }}
nodePort: {{ $.Values.coder.service.prometheusNodePort }}
{{ end }}
{{- end }}
{{- end }}
{{- end }}
{{- if eq "LoadBalancer" .Values.coder.service.type }}
{{- with .Values.coder.service.loadBalancerIP }}
loadBalancerIP: {{ . | quote }}
Expand Down
8 changes: 0 additions & 8 deletions helm/coder/tests/testdata/prometheus.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,6 @@ spec:

nodePort:


- name: "prometheus-http"
port: 2112
targetPort: "prometheus-http"
protocol: TCP

nodePort: 31112

selector:
app.kubernetes.io/name: coder
app.kubernetes.io/instance: release-name
Expand Down