chore(cli): replace clibase with external coder/serpent
#12252
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
76d9588 to
c428f86
Compare
coder/serpent instead of clibasecoder/serpent
|
@ammario what's the plan for continuing development of At the moment, we're still missing critical features like shell completion. And some basic functionality like |
|
There is no plan at the moment. It will make development marginally more difficult when trying to improve both the CLI base and coder/coder but the rate of changes (https://github.com/coder/coder/commits/main/cli/clibase) to clibase seems low enough to be insignificant. On the other side, we can improve serpent without the complex development loop and CI of coder/coder. |
|
Plus, we can submit light changes to |
|
Going to tag @kylecarbs instead to hopefully get it merged before the weekend and not deal with more conflicts. |
There was a problem hiding this comment.
Essentially rubber stamping this.
I agree with @mafredri that making significant changes may be a pain in the butt, but I think it's worthwhile for us to try and advertise serpent to other large Go services that have many configurable properties.
|
Will revisit this when I have some free cycles. |
|
OK. Merging this in now. Will move the relevant issues to the new tracker and maybe knock some out today. |
I wanted to use clibase in a new thing I'm building, so it felt like a natural moment to move it into its own repo.
Unfortunately the help code is duplicated between this repo and serpent because we coupled our help handler with Coder specific concepts and I didn't want to make this change larger.
Most of the changes are simple find and replace except for
apitypings/main.go.TODO: